The vertexCount on BoundingBoxAttachment is doubled

hahanoob

Using the spine-c runtime. The vertexCount is parsed in spSkeletonJson_readSkeletonData and multiplied by two to get the number of floats to parse:

_readVertices(self, attachmentMap, SUPER(box), Json_getInt(attachmentMap, "vertexCount", 0) << 1);

But then inside _readVertices:

attachment->verticesCount = verticesLength;

I changed it locally to this:

attachment->verticesCount = verticesLength >> 1;

It looks like PathAttachment and MeshAttachment might have the same problem. Maybe _readVertices should take vertexCount instead of the number of floats?

hahanoob

Mario

verticesCount is a bit of a misnomer. It actually does store the number of floats, not the number of elements. I'll have to convince Nate to change the name of that field to something that reflects its semantics better.

hahanoob

Oh, okay. Though it looks like worldVerticesLength already stores the number of floats? Seems odd to have both but maybe they differ in other contexts.

Mario

Yeah, I was wrong. Was a long day yesterday 🙂 I'm fixing this up in the runtime today. Thanks for reporting! See this issue on GitHub for progress: [c] VertexAttachment.vertexCount is set incorrectly · Issue #666 · EsotericSoftware/spine-runtimes · GitHub